ENT-14320: Wrapped most of the remaining cf-remote/cfbs commands into CFEngine-cli - #209
Conversation
4eef420 to
e8fa6bf
Compare
cd03c10 to
a26b902
Compare
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
| description="A wrapper around the cf-remote `build`-function with some added niceties", | ||
| ) | ||
| sp.add_argument( | ||
| "--non-interactive", |
There was a problem hiding this comment.
Isn't the whole point with CFEngine CLI that it should not be used in scripts? I feel options like --non-interactive kind of works against that. Do we already have these options for other sub commands?
There was a problem hiding this comment.
Not for most commands, only init and for build/deploy. I added them as niceties when testing a module, that way I could just do cfengine build --host HOST --non-interactive and wait for output rather than pressing enter every 5 seconds.
There was a problem hiding this comment.
We could consider
parser = argparse.ArgumentParser(prog='frobble')
parser.add_argument('--foo', help=argparse.SUPPRESS)
parser.print_help()for arguments that are only for our tests.
There was a problem hiding this comment.
I meant testing as in using. They way it would work without is that you would build, prompt if you want to deploy, then prompt if you want to run. But when working on a module/policy-set you would probably want to just fast-forward this and read the output after the full pipeline.
…dules or update cfbs project
… is specified Ticket: None Changelog: Title Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
a26b902 to
6b1a1b7
Compare
6b1a1b7 to
f9ce239
Compare
f9ce239 to
eaf82d6
Compare
No description provided.